Clarify KVM import template requirement - #13126
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13126 +/- ##
=========================================
Coverage 17.91% 17.92%
- Complexity 16109 16113 +4
=========================================
Files 5928 5928
Lines 534964 534964
Branches 65463 65463
=========================================
+ Hits 95865 95876 +11
+ Misses 428191 428180 -11
Partials 10908 10908
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package kvm |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled withkvm SystemVM template(s). I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17772 |
|
@blueorangutan test |
|
@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
@blueorangutan test ol8 kvm-ol8 keepEnv |
|
@blueorangutan test |
|
@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16173)
|
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
@andrijapanicsb the text on the description looks good, IMO the API must also check the hypervisor type and the importing operation and fail in case it is not passed for KVM import unmanaged instance.
In the UI for Migrating from VMware to KVM etc - there is no option to even select a template - seems we always (or UI does ot) assign the dummy template 
|
|
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
Code LGTM
Let's target the PR to branch 4.22 instead of main branch so can get into 4.22.2 as well
|
Hi @andrijapanicsb are you ok addressing the comment and rebasing the PR to the 4.22 branch? If not, I can help with that |
|
ping @andrijapanicsb , will you rebase (and apply my suggestion? |
…mportUnmanagedInstanceCmdTest.java unneeded
d6444de to
e26017b
Compare
…mportUnmanagedInstanceCmd.java Co-authored-by: dahn <daan@onecht.net>
|
Hi @andrijapanicsb @DaanHoogland - I have rebased the fix to branch 4.22 and applied Daan's suggestion on the parameter description @blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19189 |
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16962)
|
7 participants
Description
importUnmanagedInstancedocumentstemplateidas an optional parameter, but KVM unmanaged instance import currently requires a template and fails when one is not supplied.This updates the generated API parameter description for
templateidto explicitly mention that it is required when importing an unmanaged KVM instance. It avoids the current mismatch between API docs and runtime behavior without changing import semantics.Fixes #13067
Tests
Added
ImportUnmanagedInstanceCmdTestcoverage to verify thetemplateidAPI parameter description includes the KVM requirement. Deleted